Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r3649947054
##########
dev/vcpkg/env.sh:
##########
@@ -31,6 +31,9 @@ export
VCPKG_TRIPLET_INSTALL_DIR=${SCRIPT_ROOT}/vcpkg_installed/${VCPKG_TRIPLET}
${SCRIPT_ROOT}/init.sh "$@"
+unset PKG_CONFIG_PATH
+export
PKG_CONFIG_LIBDIR=${VCPKG_TRIPLET_INSTALL_DIR}/lib/pkgconfig:${VCPKG_TRIPLET_INSTALL_DIR}/share/pkgconfig
Review Comment:
`env.sh` unsets `PKG_CONFIG_PATH` and sets `PKG_CONFIG_LIBDIR` *after*
calling `init.sh`, but `init.sh` runs `vcpkg install`. This means the vcpkg
build can still inherit the caller’s `PKG_CONFIG_PATH` during the install phase
(the part you’re trying to isolate from `/usr/local`/conda prefixes). Reorder
these exports so they take effect before invoking `init.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
