Copilot commented on code in PR #12888:
URL: https://github.com/apache/gluten/pull/12888#discussion_r3851649585
##########
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -865,6 +866,8 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("SPARK-24583 Wrong schema type in InsertIntoDataSourceCommand")
// the native write staing dir is differnt with vanilla Spark for coustom
partition paths
.exclude("SPARK-35106: Throw exception when rename custom partition paths
returns false")
+ // The case expects a SparkException; Gluten surfaces the raw
+ // FileAlreadyExistsException instead. Reproduced on Spark 3.4.4.
Review Comment:
The comment says \"Reproduced on Spark 3.4.4\" but this is in the Spark 4.0
module settings. That can be read as a guarantee about Spark 4.0 behavior, even
if it was only validated on 3.4.4. Consider rephrasing to make the scope
explicit (e.g., \"Observed on Spark 3.4.4\" / \"At least on Spark 3.4.4\" / or
update it to the version(s) actually reproduced for this module), and apply the
same adjustment in the other modules where this comment was added.
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -374,6 +374,8 @@ class ClickHouseTestSettings extends BackendTestSettings {
.excludeCH("SPARK-33291: Cast struct with null elements to string")
.excludeCH("SPARK-35111: Cast string to year-month interval")
.excludeCH("Gluten - data type casting")
+ // Gluten rewrite of the vanilla case excluded below; not vetted on
ClickHouse.
Review Comment:
The wording \"excluded below\" is a bit ambiguous here since this line is
itself the exclusion, and the relationship between the vanilla test name and
the Gluten-prefixed test name isn’t explicit. Consider rewording to something
more direct like \"Exclude the Gluten rewrite test (\\\"Gluten - cast from
timestamp II\\\") for ClickHouse; not yet validated\" to reduce confusion when
scanning settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
