Copilot commented on code in PR #12888:
URL: https://github.com/apache/gluten/pull/12888#discussion_r3853072671
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -374,6 +374,9 @@ class ClickHouseTestSettings extends BackendTestSettings {
.excludeCH("SPARK-33291: Cast struct with null elements to string")
.excludeCH("SPARK-35111: Cast string to year-month interval")
.excludeCH("Gluten - data type casting")
+ // The Gluten rewrite of "cast from timestamp II" is not vetted on
ClickHouse;
+ // the vanilla case is excluded separately in this block.
+ .excludeCH("Gluten - cast from timestamp II")
Review Comment:
Avoid hardcoding the "Gluten - " prefix in a ClickHouse settings exclusion.
This file already uses `excludeGlutenTest(...)`, which derives the prefix from
`GlutenTestConstants.GLUTEN_TEST`; using it here prevents future drift if the
prefix changes and makes the intent clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
