Copilot commented on code in PR #12888:
URL: https://github.com/apache/gluten/pull/12888#discussion_r3852377546
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -1180,6 +1183,8 @@ class ClickHouseTestSettings extends BackendTestSettings {
enableSuite[GlutenMathExpressionsSuite]
// Spark round UT for round(3.1415,3) is not correct.
.exclude("round/bround/floor/ceil")
+ // ClickHouse's tanh differs from Spark's at the sixth significant digit:
+ // TANH(-0.1) returns -0.0996695958408681, the case expects
-0.09966799462495582.
Review Comment:
The comment says the tanh results differ at the "sixth significant digit",
but the provided values diverge earlier. Consider removing the digit-count
claim and just state the expected vs actual values to avoid an incorrect reason.
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -2195,8 +2200,14 @@ class ClickHouseTestSettings extends BackendTestSettings
{
.excludeCH("cast from timestamp II")
.excludeCH("cast a timestamp before the epoch 1970-01-01 00:00:00Z II")
.excludeCH("cast a timestamp before the epoch 1970-01-01 00:00:00Z")
+ // ClickHouse throws instead of yielding null: try_cast([123,true,f] as
+ // array<boolean>) fails with an exception.
Review Comment:
In the example expression, `f` is not a valid boolean literal in Spark SQL.
Use `false` (or remove the literal example) so the recorded exclude reason is
unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
