philo-he commented on code in PR #13115:
URL: https://github.com/apache/gluten/pull/13115#discussion_r4149028548


##########
cpp/velox/config/VeloxConfig.h:
##########
@@ -169,6 +169,10 @@ const std::string kVeloxAsyncTimeoutOnTaskStopping =
     "spark.gluten.sql.columnar.backend.velox.asyncTimeoutOnTaskStopping";
 const int32_t kVeloxAsyncTimeoutOnTaskStoppingDefault = 30000; // 30s
 
+// Size of the dedicated CPU thread pool for the parallel broadcast hash-table 
build.
+// Defaults to the number of task slots per executor, with a minimum of one 
thread.
+const std::string kHashTableBuildThreads = 
"spark.gluten.sql.columnar.backend.velox.hashTableBuildThreads";

Review Comment:
   Suggest to name it like broadcastHashTableBuildThreads since it is only 
specific to BHJ.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to