philo-he commented on code in PR #13115:
URL: https://github.com/apache/gluten/pull/13115#discussion_r4149042025
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -254,6 +255,10 @@ void VeloxBackend::init(
std::make_unique<folly::CPUThreadPoolExecutor>(ioThreads,
folly::CPUThreadPoolExecutor::makeLifoSemQueue());
}
+ const auto hashTableBuildThreads =
+ std::max<int32_t>(1, backendConf_->get<int32_t>(kHashTableBuildThreads,
numTaskSlotsPerExecutor));
+ hashTableBuildExecutor_ =
std::make_unique<folly::CPUThreadPoolExecutor>(hashTableBuildThreads);
Review Comment:
+1. This thread pool is very specific. No need to create the executor
unconditionally at backend init time though internally the threads are created
lazily.
Just noted the previous discussion. A lazy creation in accessor may also be
acceptable, since it is unlike other executors which are a bit general to use.
Not sure which is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
