Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r4153085446
##########
.github/workflows/velox_weekly.yml:
##########
@@ -20,345 +20,46 @@ on:
paths:
- '.github/workflows/velox_weekly.yml'
- 'build/mvn'
+ - 'ep/build-velox/src/**'
Review Comment:
The replacement workflow does not preserve the PR coverage removed with
`velox_backend_x86.yml`, `velox_backend_arm.yml`, and
`velox_backend_enhanced.yml`: this path filter excludes `cpp/**`, `dev/**`,
`backends-velox/**`, and the other backend paths those workflows covered, while
the remaining `velox_nightly.yml` is schedule/main-only. As a result, this PR's
native/vcpkg changes—and future Velox backend PRs—lose their normal build,
unit-test, and TPC gates. These removals are unrelated to #7139 and are not
described in the PR; restore the workflows or add equivalent pull-request
coverage.
This issue also appears on line 31 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
