baibaichen commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r4162937013
##########
ep/build-velox/src/setup-openeuler24.sh:
##########
@@ -252,8 +252,8 @@ function install_velox_deps {
function install_s3 {
install_aws_deps
- local MINIO_OS="linux"
- install_minio ${MINIO_OS}
+ local SILO_OS="linux"
+ install_silo ${SILO_OS}
Review Comment:
`install_silo` is available in the actual caller environment.
`dev/builddeps-veloxbe.sh::setup_dependencies` sources
`${VELOX_HOME}/scripts/setup-common.sh` before `setup_linux` sources
`setup-openeuler24.sh`; `setup-common.sh` defines `install_silo`. The final
openEuler Weekly run also executed `install_silo linux` successfully and
completed the job, so sourcing `setup-common.sh` again in the distro script is
unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
