Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r4158708346
##########
ep/build-velox/src/setup-openeuler24.sh:
##########
@@ -252,8 +252,8 @@ function install_velox_deps {
function install_s3 {
install_aws_deps
- local MINIO_OS="linux"
- install_minio ${MINIO_OS}
+ local SILO_OS="linux"
+ install_silo ${SILO_OS}
Review Comment:
`install_silo` is defined by Velox's `scripts/setup-common.sh`, but this
script only sources `setup-helper-functions.sh` at line 33. Consequently, the
openEuler S3 setup reaches this line with no such function and exits with
`command not found`. Source `setup-common.sh` (which also sources the helper
file), or otherwise import the Silo installer before this call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
