ggjh-159 commented on code in PR #13459:
URL: https://github.com/apache/gluten/pull/13459#discussion_r4408387868
##########
.github/workflows/flink.yml:
##########
@@ -87,9 +87,9 @@ jobs:
export VELOX_DEPENDENCY_SOURCE=BUNDLED
export fmt_SOURCE=BUNDLED
export folly_SOURCE=BUNDLED
- git clone -b gluten-20260829 https://github.com/bigo-sg/velox4j.git
+ git clone -b stringExpr https://github.com/zhang-jianq/velox4j.git
cd velox4j
- git reset --hard 26c7715278e6f6795084f6334998cb2ce382f7aa
+ git reset --hard d651d15a5e759dc68c15aa6f7a22d9c21725c02b
Review Comment:
The CI clone does `git clone -b stringExpr` followed by `git reset --hard
d651d15a` — cloning the dev branch and then resetting to a commit degenerates
back to commit tracking, so later pushes to the velox / velox4j branches are
never exercised and CI keeps going green on the stale sha, misleading
re-reviews. Drop the reset line during the dev phase (actually track the
branch) and restore the commit pinning once the stack lands back on
`gluten-20260829`. For Flink.md, revert this edit rather than mirroring the CI
wiring — keep the docs on the official `bigo-sg` / `gluten-20260829` ref during
development, and update them once with the final commit after the velox-side
PRs merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
