zhang-jianq commented on PR #13459: URL: https://github.com/apache/gluten/pull/13459#issuecomment-6620305046
> The four SQL-level tests are single-shape happy paths. Per-function gaps: LIKE — no escape-character case (including a non-ASCII escape), no `_` wildcard case, and no escaped-literal `%` / `_` case; REPLACE — no empty-`from` case (the Flink-vs-Spark distinguishing semantic) and no multibyte input; RIGHT — no `n <= 0` / `n >= len` boundaries and no beyond-length multibyte case; FROM_BASE64 — no empty input and no invalid-input error path. Extend the tests along these dimensions. Thanks for review, it's done. Extended the four SQL-level tests along the requested dimensions: LIKE (escape incl. non-ASCII, `_` wildcard, escaped-literal `%`/`_`), REPLACE (empty `from` with multibyte input), RIGHT (`n<=0`/`n>=len` and beyond-length multibyte), FROM_BASE64 (empty input, unpadded input, and invalid-input error path). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
