vectorijk commented on code in PR #13035:
URL: https://github.com/apache/gluten/pull/13035#discussion_r4429669002
##########
cpp/velox/substrait/SubstraitToVeloxExpr.cc:
##########
@@ -567,24 +611,37 @@ VectorPtr SubstraitVeloxExprConverter::literalsToVector(
}
return rowVector;
}
- default:
+ default: {
+ // if null, get null type instead of next element type
auto veloxType = getScalarType(elementAtFunc(0));
if (veloxType) {
- auto kind = veloxType->kind();
- return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH(
- constructFlatVector, kind, elementAtFunc, childSize, veloxType,
pool_);
+ // Handle UNKNOWN type (untyped nulls like array(null)) by creating
Review Comment:
Sounds good. update the comments for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
