philo-he commented on code in PR #13035:
URL: https://github.com/apache/gluten/pull/13035#discussion_r4489695460
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxLiteralSuite.scala:
##########
@@ -133,10 +146,15 @@ class VeloxLiteralSuite extends
VeloxWholeStageTransformerSuite {
validateOffloadResult("SELECT TIMESTAMP'2020-12-31',
TIMESTAMP'2020-12-30'")
validateOffloadResult("SELECT X'1234', X'a'")
validateOffloadResult("SELECT DATE'2020-12-31', DATE'2020-12-30'")
- }
+ validateOffloadResult("select CAST(null as struct<u:integer,v:string>)")
+ validateOffloadResult("SELECT array(struct(1, 'a'), null, struct(1, 'a'))")
+ validateOffloadResult(
+ "select array(struct(1, 'a'), " +
+ "CAST(null AS struct<col1:integer,col2:string>))"
+ )
- test("Literal Fallback") {
- validateFallbackResult("SELECT struct(cast(null as struct<a: string>))")
- validateFallbackResult("SELECT array(struct(1, 'a'), null)")
+ validateOffloadResult("SELECT struct(cast(null as struct<a: string>))")
+ validateOffloadResult("select array(null, array(\'str\', \'a\'))")
+ validateOffloadResult("select array(null)")
Review Comment:
This seems to duplicate line 122.
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxLiteralSuite.scala:
##########
@@ -111,14 +111,27 @@ class VeloxLiteralSuite extends
VeloxWholeStageTransformerSuite {
test("Null Literal") {
validateOffloadResult("SELECT cast(null as int)")
validateOffloadResult("SELECT cast(null as decimal)")
+ validateOffloadResult("select CAST(null as struct<u:integer,v:string>)")
validateOffloadResult("SELECT array(5, 1, null)")
validateOffloadResult("SELECT array(5.321E2BD, 0.1, null)")
validateOffloadResult("SELECT struct('Spark', cast(null as int))")
validateOffloadResult("SELECT struct(cast(null as decimal))")
validateOffloadResult("SELECT map('b', 'a', 'e', null)")
- validateOffloadResult("SELECT array(null)")
validateOffloadResult("SELECT array(cast(null as int))")
validateOffloadResult("SELECT map(1, null)")
+ validateOffloadResult("SELECT array(null)")
+
+ validateOffloadResult("SELECT array(array(1,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1.0,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1, 2), null)")
+
+ validateOffloadResult("SELECT array( null, 2, 3.0)")
+ validateOffloadResult("SELECT array(1, 0, null, 2, 3)")
+ validateOffloadResult("select array(null, array(null, array(1,2),
array(2)), null)")
+ validateOffloadResult("select array(null, array(1, 2))")
+ validateOffloadResult("select array(null, array(null, 1, 2))")
+ validateOffloadResult("select array(null, array(1, 2, null), null)")
+ validateOffloadResult("select array(null, array(null, array(1, 2), null,
array(1)))")
Review Comment:
Nit: can we use "SELECT", all in upper case, for consistency?
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxLiteralSuite.scala:
##########
@@ -111,14 +111,27 @@ class VeloxLiteralSuite extends
VeloxWholeStageTransformerSuite {
test("Null Literal") {
validateOffloadResult("SELECT cast(null as int)")
validateOffloadResult("SELECT cast(null as decimal)")
+ validateOffloadResult("select CAST(null as struct<u:integer,v:string>)")
validateOffloadResult("SELECT array(5, 1, null)")
validateOffloadResult("SELECT array(5.321E2BD, 0.1, null)")
validateOffloadResult("SELECT struct('Spark', cast(null as int))")
validateOffloadResult("SELECT struct(cast(null as decimal))")
validateOffloadResult("SELECT map('b', 'a', 'e', null)")
- validateOffloadResult("SELECT array(null)")
validateOffloadResult("SELECT array(cast(null as int))")
validateOffloadResult("SELECT map(1, null)")
+ validateOffloadResult("SELECT array(null)")
+
+ validateOffloadResult("SELECT array(array(1,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1.0,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1, 2), null)")
+
+ validateOffloadResult("SELECT array( null, 2, 3.0)")
Review Comment:
Nit: This has an extra space after "(".
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxLiteralSuite.scala:
##########
@@ -133,10 +146,15 @@ class VeloxLiteralSuite extends
VeloxWholeStageTransformerSuite {
validateOffloadResult("SELECT TIMESTAMP'2020-12-31',
TIMESTAMP'2020-12-30'")
validateOffloadResult("SELECT X'1234', X'a'")
validateOffloadResult("SELECT DATE'2020-12-31', DATE'2020-12-30'")
- }
+ validateOffloadResult("select CAST(null as struct<u:integer,v:string>)")
+ validateOffloadResult("SELECT array(struct(1, 'a'), null, struct(1, 'a'))")
+ validateOffloadResult(
+ "select array(struct(1, 'a'), " +
+ "CAST(null AS struct<col1:integer,col2:string>))"
+ )
- test("Literal Fallback") {
- validateFallbackResult("SELECT struct(cast(null as struct<a: string>))")
- validateFallbackResult("SELECT array(struct(1, 'a'), null)")
+ validateOffloadResult("SELECT struct(cast(null as struct<a: string>))")
+ validateOffloadResult("select array(null, array(\'str\', \'a\'))")
Review Comment:
Unneeded escapes. \'str\', \'a\' inside a Scala double-quoted string can
just be 'str', 'a'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
