vectorijk commented on code in PR #13035:
URL: https://github.com/apache/gluten/pull/13035#discussion_r4500535345
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxLiteralSuite.scala:
##########
@@ -111,14 +111,27 @@ class VeloxLiteralSuite extends
VeloxWholeStageTransformerSuite {
test("Null Literal") {
validateOffloadResult("SELECT cast(null as int)")
validateOffloadResult("SELECT cast(null as decimal)")
+ validateOffloadResult("select CAST(null as struct<u:integer,v:string>)")
validateOffloadResult("SELECT array(5, 1, null)")
validateOffloadResult("SELECT array(5.321E2BD, 0.1, null)")
validateOffloadResult("SELECT struct('Spark', cast(null as int))")
validateOffloadResult("SELECT struct(cast(null as decimal))")
validateOffloadResult("SELECT map('b', 'a', 'e', null)")
- validateOffloadResult("SELECT array(null)")
validateOffloadResult("SELECT array(cast(null as int))")
validateOffloadResult("SELECT map(1, null)")
+ validateOffloadResult("SELECT array(null)")
+
+ validateOffloadResult("SELECT array(array(1,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1.0,2), null, array(1), null)")
+ validateOffloadResult("SELECT array(array(1, 2), null)")
+
+ validateOffloadResult("SELECT array( null, 2, 3.0)")
+ validateOffloadResult("SELECT array(1, 0, null, 2, 3)")
+ validateOffloadResult("select array(null, array(null, array(1,2),
array(2)), null)")
+ validateOffloadResult("select array(null, array(1, 2))")
+ validateOffloadResult("select array(null, array(null, 1, 2))")
+ validateOffloadResult("select array(null, array(1, 2, null), null)")
+ validateOffloadResult("select array(null, array(null, array(1, 2), null,
array(1)))")
Review Comment:
Cool, thanks! Fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
