zhang-jianq commented on code in PR #13472:
URL: https://github.com/apache/gluten/pull/13472#discussion_r4439856920
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/RexNodeConverter.java:
##########
@@ -98,6 +98,9 @@ public static Type toType(RelDataType relDataType) {
}
public static Variant toVariant(RexLiteral literal) {
Review Comment:
@lgbo-ustc thanks for the detailed review. This one is now aligned with the
IFNULL change by rebase: the branch has picked up the toNullVariant helper from
[apache/gluten#13375](https://github.com/apache/gluten/pull/13375), which still
uses VarCharValue(null) as the null carrier. I'd argue the mismatch you
describe doesn't actually happen on the velox side — for a null constant,
ConstantTypedExpr::toConstantVector ignores the variant kind and builds the
null vector from the expression type (BaseVector::createNullConstant(type(),
...)), so an IntegerType expression with a VarCharValue(null) is fine. The
related test cases have also been added in [apache/gluten#13375
RexNodeConverterTest.java](https://github.com/apache/gluten/pull/13375/changes#diff-5372721dbe8f09c795bf71ab6ed9b6d16f28e025d753f788a17a65a1657dfc75).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
