justinmclean commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2136901747
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java:
##########
@@ -77,6 +77,12 @@ public class ExpressionUtil {
"(" + IDENTIFIER + ")\\s+" + SORT_DIRECTION + "\\s+" + NULL_ORDERING,
Pattern.CASE_INSENSITIVE);
+ /**
+ * Converts an array of transforms to a list of partition fields.
+ *
+ * @param transforms the array of transforms
+ * @return the list of partition fields
+ */
Review Comment:
While this is correct, it might be better to mention expressions here?
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java:
##########
@@ -92,6 +98,12 @@ public static List<String>
expressionToPartitionFiled(Transform[] transforms) {
}
}
+ /**
+ * Converts a list of partition fields to an array of transforms.
+ *
+ * @param partitions the list of partition fields
+ * @return the array of transforms
+ */
Review Comment:
While this is correct, it might be better to mention expressions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
