justinmclean commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2136896793
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogConnectorMetadataAdapter.java:
##########
@@ -45,12 +45,28 @@
public class CatalogConnectorMetadataAdapter {
private static final Logger LOG =
LoggerFactory.getLogger(CatalogConnectorMetadataAdapter.class);
+
+ /** The list of schema properties supported by this catalog connector. */
protected final List<PropertyMetadata<?>> schemaProperties;
+
+ /** The list of table properties supported by this catalog connector. */
protected final List<PropertyMetadata<?>> tableProperties;
+
+ /** The list of column properties supported by this catalog connector. */
protected final List<PropertyMetadata<?>> columnProperties;
+ /** The data type transformer used to convert between Gravitino and Trino
types. */
protected final GeneralDataTypeTransformer dataTypeTransformer;
Review Comment:
I'd remove the comments above they don't really add any value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
