justinmclean commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2136905623
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -29,25 +29,37 @@
import java.util.Properties;
import org.apache.commons.lang3.StringUtils;
+/** Gravitino config. */
public class GravitinoConfig {
// Trino config keys
+ /** The Trino discovery URI. */
private static final String TRINO_DISCOVERY_URI = "discovery.uri";
+ /** The Trino catalog config directory. */
private static final String TRINO_CATALOG_CONFIG_DIR = "catalog.config-dir";
+ /** The Trino plugin bundles. */
public static final String TRINO_PLUGIN_BUNDLES = "plugin.bundles";
+ /** The Trino catalog store. */
public static final String TRINO_CATALOG_STORE = "catalog.store";
+ /** The Trino catalog management. */
public static final String TRINO_CATALOG_MANAGEMENT = "catalog.management";
Review Comment:
However, if they are required by Javadocs to remove warnings, then that's
okay - as I mentioned in my other comments below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
