KyleLin0927 commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2155934167
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -29,25 +29,37 @@
import java.util.Properties;
import org.apache.commons.lang3.StringUtils;
+/** Gravitino config. */
public class GravitinoConfig {
// Trino config keys
+ /** The Trino discovery URI. */
private static final String TRINO_DISCOVERY_URI = "discovery.uri";
+ /** The Trino catalog config directory. */
private static final String TRINO_CATALOG_CONFIG_DIR = "catalog.config-dir";
+ /** The Trino plugin bundles. */
public static final String TRINO_PLUGIN_BUNDLES = "plugin.bundles";
+ /** The Trino catalog store. */
public static final String TRINO_CATALOG_STORE = "catalog.store";
+ /** The Trino catalog management. */
public static final String TRINO_CATALOG_MANAGEMENT = "catalog.management";
// Trino config default value
+ /** The Trino catalog config directory default value. */
private static final String TRINO_CATALOG_CONFIG_DIR_DEFAULT_VALUE =
"etc/catalog";
+ /** The Trino catalog store default value. */
public static final String TRINO_CATALOG_STORE_DEFAULT_VALUE = "file";
+ /** The Trino catalog management default value. */
public static final String TRINO_CATALOG_MANAGEMENT_DEFAULT_VALUE = "static";
// The Trino configuration of etc/config.properties
+ /** The Trino configuration. */
public static final TrinoConfig trinoConfig = new TrinoConfig();
// Gravitino config keys
+ /** The Gravitino dynamic connector. */
public static final String GRAVITINO_DYNAMIC_CONNECTOR =
"__gravitino.dynamic.connector";
+ /** The Gravitino dynamic connector catalog config. */
public static final String GRAVITINO_DYNAMIC_CONNECTOR_CATALOG_CONFIG =
"__gravitino.dynamic.connector.catalog.config";
Review Comment:
I’ve checked these are indeed required to prevent warning messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
