yuqi1129 commented on code in PR #7820: URL: https://github.com/apache/gravitino/pull/7820#discussion_r2242059375
########## docs/flink-connector/flink-connector.md: ########## @@ -29,24 +29,35 @@ This capability allows users to perform federation queries, accessing data from 1. [Build](../how-to-build.md) or [download](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-flink-connector-runtime-1.18) the Gravitino flink connector runtime jar, and place it to the classpath of Flink. 2. Configure the Flink configuration to use the Gravitino flink connector. -| Property | Type | Default Value | Description | Required | Since Version | -|--------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| -| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| Property | Type | Default Value | Description | Required | Since Version | +|--------------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| +| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.client.config. | string | (none) | The configuration key prefix for the Gravitino client config. | No | 1.0.0 | + +To configure the Gravitino client, use properties prefixed with `table.catalog-store.gravitino.gravitino.client.config.`. These properties undergo automatic transformation: the prefix is replaced with `gravitino.client.` and passed to the `GravitinoClient`. + +**Example:** Setting `table.catalog-store.gravitino.gravitino.client.config.socketTimeoutMs` is equivalent to setting `gravitino.client.socketTimeoutMs` for the `GravitinoClient`. + +**Note:** Invalid configuration properties will result in exceptions. Please see [Gravitino Java client configurations](./how-to-use-java-client.md#gravitino-java-client-configuration) for more support client configuration. Review Comment: Do you mean that if we pass an unknown property to Gravitino, an exception will occur? ########## docs/flink-connector/flink-connector.md: ########## @@ -29,24 +29,35 @@ This capability allows users to perform federation queries, accessing data from 1. [Build](../how-to-build.md) or [download](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-flink-connector-runtime-1.18) the Gravitino flink connector runtime jar, and place it to the classpath of Flink. 2. Configure the Flink configuration to use the Gravitino flink connector. -| Property | Type | Default Value | Description | Required | Since Version | -|--------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| -| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| Property | Type | Default Value | Description | Required | Since Version | +|--------------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| +| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.client.config. | string | (none) | The configuration key prefix for the Gravitino client config. | No | 1.0.0 | + +To configure the Gravitino client, use properties prefixed with `table.catalog-store.gravitino.gravitino.client.config.`. These properties undergo automatic transformation: the prefix is replaced with `gravitino.client.` and passed to the `GravitinoClient`. Review Comment: It's a little weird that double `gravitino` exists in the key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
