FANNG1 commented on code in PR #7820:
URL: https://github.com/apache/gravitino/pull/7820#discussion_r2255739803
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -38,22 +38,27 @@ public class GravitinoCatalogManager {
private final GravitinoMetalake metalake;
private final GravitinoAdminClient gravitinoClient;
- private GravitinoCatalogManager(String gravitinoUri, String metalakeName) {
- this.gravitinoClient = GravitinoAdminClient.builder(gravitinoUri).build();
+ private GravitinoCatalogManager(
+ String gravitinoUri, String metalakeName, Map<String, String>
properties) {
Review Comment:
`properties` is a general name, I may think, does it contain catalog
properties? suggest using a specific name like `gravitinoClientOptions`
##########
docs/spark-connector/spark-connector.md:
##########
@@ -36,13 +36,22 @@ Gravitino Spark connector doesn't support Scala 2.13 for
Spark3.3.
| spark.sql.gravitino.metalake | string | (none) | The
metalake name that spark connector used to request to Gravitino.
| Yes | 0.5.0 |
| spark.sql.gravitino.uri | string | (none) | The uri
of Gravitino server address.
| Yes | 0.5.0 |
| spark.sql.gravitino.enableIcebergSupport | string | `false` | Set to
`true` to use Iceberg catalog.
| No | 0.5.1 |
+| spark.sql.gravitino.client.config. | string | (none) | The
configuration key prefix for the Gravitino client config.
| No | 1.0.0 |
Review Comment:
seem for `config`
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStoreFactory.java:
##########
@@ -80,6 +85,17 @@ public Set<ConfigOption<?>> requiredOptions() {
@Override
public Set<ConfigOption<?>> optionalOptions() {
- return Collections.emptySet();
+ return ImmutableSet.of(GRAVITINO_CLIENT_CONFIG);
Review Comment:
It's a little odd to add `GRAVITINO_CLIENT_CONFIG` here, since it's config
prefix not config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
