hqbhoho commented on code in PR #7820: URL: https://github.com/apache/gravitino/pull/7820#discussion_r2255719492
########## docs/flink-connector/flink-connector.md: ########## @@ -29,24 +29,35 @@ This capability allows users to perform federation queries, accessing data from 1. [Build](../how-to-build.md) or [download](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-flink-connector-runtime-1.18) the Gravitino flink connector runtime jar, and place it to the classpath of Flink. 2. Configure the Flink configuration to use the Gravitino flink connector. -| Property | Type | Default Value | Description | Required | Since Version | -|--------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| -| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | -| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| Property | Type | Default Value | Description | Required | Since Version | +|--------------------------------------------------------|--------|-------------------|----------------------------------------------------------------------|----------|------------------| +| table.catalog-store.kind | string | generic_in_memory | The Catalog Store name, it should set to `gravitino`. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.metalake | string | (none) | The metalake name that flink connector used to request to Gravitino. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.uri | string | (none) | The uri of Gravitino server address. | Yes | 0.6.0-incubating | +| table.catalog-store.gravitino.gravitino.client.config. | string | (none) | The configuration key prefix for the Gravitino client config. | No | 1.0.0 | Review Comment: Future versions may support config such as `table.catalog-store.gravitino.client.request.header.`. The `gravitino.client.config.` prefix is currently used to denote client-specific configurations. This seems clearer to me. In GVFS, We have added support for configuring request headers via `fs.gravitino.client.request.header.` prefixed properties. To maintain consistency and avoid special-case filtering logic in the codebase, it is preferable to centralize all client configurations under the `fs.gravitino.client.config.` prefix. This unified approach streamlines configuration management. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
