Copilot commented on code in PR #9430:
URL: https://github.com/apache/gravitino/pull/9430#discussion_r2645271673
##########
scripts/postgresql/schema-1.2.0-postgresql.sql:
##########
@@ -0,0 +1,786 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file--
Review Comment:
The schema file has a syntax error in the comment on line 3. The opening
comment delimiter appears twice, causing a malformed comment block. This will
cause SQL parsing errors.
##########
scripts/h2/schema-1.2.0-h2.sql:
##########
@@ -0,0 +1,451 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file--
Review Comment:
The schema file has a syntax error in the comment on line 3. The opening
comment delimiter appears twice, causing a malformed comment block. This will
cause SQL parsing errors.
##########
scripts/mysql/schema-1.2.0-mysql.sql:
##########
@@ -0,0 +1,442 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file--
Review Comment:
The schema file has a syntax error in the comment on line 3. The opening
comment delimiter appears twice, causing a malformed comment block. This will
cause SQL parsing errors.
```suggestion
-- or more contributor license agreements. See the NOTICE file
```
##########
core/src/test/java/org/apache/gravitino/storage/TestEntityStorage.java:
##########
@@ -157,14 +165,16 @@ private void init(String type, Config config) {
Mockito.when(config.get(STORE_DELETE_AFTER_TIME)).thenReturn(20 * 60 *
1000L);
Mockito.when(config.get(VERSION_RETENTION_COUNT)).thenReturn(1L);
// Fix cache config for test
- Mockito.when(config.get(Configs.CACHE_ENABLED)).thenReturn(true);
+ // Mockito.when(config.get(Configs.CACHE_ENABLED)).thenReturn(true);
Review Comment:
Commented out configuration line without explanation. The line
`Mockito.when(config.get(Configs.CACHE_ENABLED)).thenReturn(true);` is
commented out but there's no explanation why. This change appears to rely on
the enableCache parameter passed to the test method, but leaving commented code
without context is confusing and violates clean code practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
