yuqi1129 commented on code in PR #9430:
URL: https://github.com/apache/gravitino/pull/9430#discussion_r2650794372
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/FilesetMetaService.java:
##########
@@ -182,15 +194,7 @@ public void insertFileset(FilesetEntity filesetEntity,
boolean overwrite) throws
baseMetricName = "updateFileset")
public <E extends Entity & HasIdentifier> FilesetEntity updateFileset(
NameIdentifier identifier, Function<E, E> updater) throws IOException {
- NameIdentifierUtil.checkFileset(identifier);
-
- String filesetName = identifier.name();
-
- Long schemaId =
- EntityIdService.getEntityId(
- NameIdentifier.of(identifier.namespace().levels()),
Entity.EntityType.SCHEMA);
-
- FilesetPO oldFilesetPO = getFilesetPOBySchemaIdAndName(schemaId,
filesetName);
+ FilesetPO oldFilesetPO = getFilesetPOByIdentifier(identifier);
Review Comment:
Yeah, I think so, and will create an issue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
