jerryshao commented on code in PR #9430:
URL: https://github.com/apache/gravitino/pull/9430#discussion_r2650672847
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/FilesetMetaService.java:
##########
@@ -347,6 +350,38 @@ public int deleteFilesetVersionsByRetentionCount(Long
versionRetentionCount, int
return totalDeletedCount;
}
+ private FilesetPO getFilesetPOByIdentifier(NameIdentifier identifier) {
+ NameIdentifierUtil.checkFileset(identifier);
+
+ if (GravitinoEnv.getInstance().config().get(Configs.CACHE_ENABLED)) {
+ Long schemaId =
+ EntityIdService.getEntityId(
+ NameIdentifier.of(identifier.namespace().levels()),
Entity.EntityType.SCHEMA);
+ return getFilesetPOBySchemaIdAndName(schemaId, identifier.name());
+ }
Review Comment:
Also here. If the implementor should base on whether cache is enabled to
write different code, it is somehow hard for others to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
