roryqi commented on code in PR #10671:
URL: https://github.com/apache/gravitino/pull/10671#discussion_r3295823149
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -192,6 +194,12 @@ public ListNamespacesResponse listNamespace(Namespace
parent) {
return CatalogHandlers.listNamespaces(getNamespaceCatalog(), parent);
}
+ public ListNamespacesResponse listNamespace(
+ Namespace parent, @Nullable String pageToken, @Nullable Integer
pageSize) {
Review Comment:
Could u use Optional instead of Nullable annotation here? Because Optional
will make others consider null value explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
