laserninja commented on code in PR #10671:
URL: https://github.com/apache/gravitino/pull/10671#discussion_r3296169311
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -192,6 +194,12 @@ public ListNamespacesResponse listNamespace(Namespace
parent) {
return CatalogHandlers.listNamespaces(getNamespaceCatalog(), parent);
}
+ public ListNamespacesResponse listNamespace(
+ Namespace parent, @Nullable String pageToken, @Nullable Integer
pageSize) {
Review Comment:
refactored to use Optional<String> pageToken and Optional<Integer> pageSize
throughout the dispatcher chain in a previous commit (43c51a07). In this latest
push, I moved pagination out of the dispatcher chain entirely into the REST
layer (IcebergPaginationHelper), so the dispatcher interfaces no longer carry
pagination params at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
