mchades commented on code in PR #14124:
URL: https://github.com/apache/gravitino/pull/14124#discussion_r4344357001
##########
api/src/main/java/org/apache/gravitino/file/FilesetChange.java:
##########
@@ -25,7 +25,8 @@
/**
* A fileset change is a change to a fileset. It can be used to rename a
fileset, update the comment
- * of a fileset, set a property and value pair for a fileset, or remove a
property from a fileset.
+ * or type of a fileset, set a property and value pair for a fileset, or
remove a property from a
+ * fileset.
Review Comment:
I’ve listed comment updates and type updates separately.
##########
clients/client-python/gravitino/api/file/fileset_change.py:
##########
@@ -20,12 +20,13 @@
from dataclasses_json import config
+from gravitino.api.file.fileset import Fileset
from gravitino.api.secret import SecretBinding, SecretReference
class FilesetChange(ABC):
"""A fileset change is a change to a fileset. It can be used to rename a
fileset, update the comment
- of a fileset, set a property and value pair for a fileset, or remove a
property from a fileset.
+ or type of a fileset, set a property and value pair for a fileset, or
remove a property from a fileset.
"""
Review Comment:
I’ve listed the operations separately and kept the wording consistent with
the Java API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
