mchades commented on code in PR #14124:
URL: https://github.com/apache/gravitino/pull/14124#discussion_r4346192589
##########
docs/manage-fileset-metadata-using-gravitino.md:
##########
@@ -183,6 +184,50 @@ Fileset fileset = filesets.alterFileset(
</TabItem>
</Tabs>
+#### Change the Fileset Type
+
+An existing fileset can be changed between `MANAGED` and `EXTERNAL`. This
changes metadata only:
+its identifier, name, storage locations, properties, and existing files are
preserved. Setting the
+current type is allowed.
+
+Change a `MANAGED` fileset to `EXTERNAL` before dropping it to retain its
files. Changing an
Review Comment:
I clarified that managed data deletion requires filesystem operations to be
enabled. With `disable-filesystem-ops=true`, drop removes only metadata.
##########
clients/client-python/gravitino/api/file/fileset_change.py:
##########
@@ -191,6 +212,26 @@ def __str__(self):
"""
return f"UPDATEFILESETCOMMENT {self._new_comment}"
+ @dataclass
+ class UpdateFilesetType:
+ """A fileset change to update the type without changing data or
locations."""
+
+ _new_type: Fileset.Type = field(metadata=config(field_name="newType"))
Review Comment:
I switched the change object’s field metadata to `new_type` and added an
explicit `__eq__` to match the other change classes. The request DTO still uses
`newType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
