mchades commented on code in PR #14124:
URL: https://github.com/apache/gravitino/pull/14124#discussion_r4346189355
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -1299,6 +1300,8 @@ private FilesetEntity updateFilesetEntity(
newName = ((FilesetChange.RenameFileset) change).getNewName();
} else if (change instanceof FilesetChange.UpdateFilesetComment) {
newComment = ((FilesetChange.UpdateFilesetComment)
change).getNewComment();
+ } else if (change instanceof FilesetChange.UpdateFilesetType) {
Review Comment:
I kept type conversion under the existing `alterFileset` authorization,
consistent with `WRITE_FILESET` allowing data writes and metadata changes. I
documented this and added an authorization test showing that a writer can
convert both ways but still cannot drop the fileset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
