nicknezis commented on a change in pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#discussion_r728385601
##########
File path: deploy/kubernetes/general/apiserver.yaml
##########
@@ -95,6 +95,7 @@ spec:
-D
heron.uploader.dlog.topologies.namespace.uri=distributedlog://zookeeper:2181/heron
-D
heron.statefulstorage.classname=org.apache.heron.statefulstorage.dlog.DlogStorage
-D
heron.statefulstorage.dlog.namespace.uri=distributedlog://zookeeper:2181/heron
+ # -D heron.kubernetes.pod.template.configmap.disabled=true
Review comment:
Perhaps we keep it, but chose a default value and uncomment it? My vote
would be for `configmap.disabled=false` as this is the default behavior in
Spark. But I agree it is good to keep it present so that an admin is aware of
the toggle.
Another thought I just had is that we might want to update any other
Kubernetes deployment yamls for API Server. For
example, there is an equivalent file in the Helm chart. This would ideally
be templatized to expose this toggle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
