surahman commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-943445404
> I didn't realize I had the ability to push to your branch.
These permissions are part of the GH PR workflow and are only on the PR
branch. You will not be able to push to the `dev` branch. GH assigns itself
permissions, for inline code suggestion committing, as well as for assignees
for the PR branch.
> I made the Helm chart update so that should be good.
Thank you 😄
> We should also make `getPodTemplateConfigMapDisabled(Config config)`
return `false` by default when it isn't set so that it is consistent with the
yamls.
It should already do this and the tests in `KubernetesContextTest` confirm
this:
```java
Assert.assertFalse(KubernetesContext.getPodTemplateConfigMapDisabled(config));
Assert.assertFalse(KubernetesContext
.getPodTemplateConfigMapDisabled(configWithPodTemplateConfigMap));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
