nicknezis commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-943297568


   We should also make `getPodTemplateConfigMapDisabled(Config config)` return 
`false` by default when it isn't set so that it is consistent with the yamls.
   
   For the Helm chart, we just need the add the following line to `tools.yaml`:
   ```
   -D heron.kubernetes.pod.template.configmap.disabled={{ 
.Values.disablePodTemplates }}
   ```
   And in the `values.yaml.template`:
   ```
   # Support for ConfigMap mounted PodTemplates
   disablePodTemplates: false
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to