surahman commented on pull request #3725:
URL: https://github.com/apache/incubator-heron/pull/3725#issuecomment-962238294


   Thank you @nicknezis that is very helpful info!
   
   I think we can add two selector labels to the PVC:
   
   ```yaml
   selector:
     topology: <topology-name>
     onDemand: true
   ```
   
   Then we can form the `labelSelector` as:
   
   ```java
   topology=<topology-name>,onDemand=true
   ```
   
   I think this should be minimally specific enough to act as a candidate key 
to select all PVC's associated with a specific topology.
   
   As for the `Claim Name` I think we need something unique enough to not cause 
collisions in the cluster:
   
   ```java
   ondemand-[Topology Name]-[Volume-Name]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to