surahman commented on pull request #3725: URL: https://github.com/apache/incubator-heron/pull/3725#issuecomment-963306214
Thank you for looking into this and confirming my suspicion, I genuinely appreciate having someone else looking over things as well :smile:. I have confused `matchLabels` with `labels` that are matched to rather than ones that will be matched to other resources. I have run the full battery of tests locally as well as completed deployment testing. I believe the production code is stable enough for broader testing. I will be reviewing the test suite and expanding it if necessary. The only addition I feel I can make to the production code is to validate input for lowercase `RFC-1123` compliance. This will slow the code down because of regex matching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
