Rachelint commented on code in PR #1271:
URL:
https://github.com/apache/incubator-horaedb/pull/1271#discussion_r1444236743
##########
analytic_engine/src/memtable/mod.rs:
##########
@@ -63,7 +67,54 @@ impl ToString for MemtableType {
fn to_string(&self) -> String {
match self {
MemtableType::SkipList => MEMTABLE_TYPE_SKIPLIST.to_string(),
- MemtableType::Columnar => MEMTABLE_TYPE_COLUMNAR.to_string(),
+ MemtableType::Column => MEMTABLE_TYPE_COLUMNAR.to_string(),
+ }
+ }
+}
+
+/// Layered memtable options
+/// If `mutable_segment_switch_threshold` is set zero, layered memtable will be
+/// disable.
+#[derive(Debug, Clone, Deserialize, PartialEq, Serialize)]
+#[serde(default)]
+pub struct LayeredMemtableOptions {
+ pub mutable_segment_switch_threshold: ReadableSize,
Review Comment:
We will also set it from config, `ReadableSize` may be preferable in config
situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
