Rachelint commented on code in PR #1271:
URL:
https://github.com/apache/incubator-horaedb/pull/1271#discussion_r1444239553
##########
analytic_engine/src/sst/parquet/async_reader.rs:
##########
@@ -540,10 +540,21 @@ impl Stream for RecordBatchProjector {
}
projector.metrics.row_num += record_batch.num_rows();
- let projected_batch =
-
FetchedRecordBatch::try_new(&projector.row_projector, record_batch)
- .box_err()
- .context(DecodeRecordBatch {});
+ let fetched_schema =
projector.row_projector.fetched_schema().clone();
+ let primary_key_indexes = projector
+ .row_projector
+ .primary_key_indexes()
+ .map(|idxs| idxs.to_vec());
Review Comment:
It has actually... but happen in `FetchedRecordBatch::try_new`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
