Rachelint commented on code in PR #1271:
URL:
https://github.com/apache/incubator-horaedb/pull/1271#discussion_r1444237769
##########
analytic_engine/src/table/data.rs:
##########
@@ -315,7 +317,23 @@ impl TableData {
let memtable_factory: MemTableFactoryRef = match opts.memtable_type {
MemtableType::SkipList => Arc::new(SkiplistMemTableFactory),
- MemtableType::Columnar => Arc::new(ColumnarMemTableFactory),
+ MemtableType::Column => Arc::new(ColumnarMemTableFactory),
+ };
+
+ // Wrap it by `LayeredMemtable`.
+ let mutable_segment_switch_threshold = opts
+ .layered_memtable_opts
+ .mutable_segment_switch_threshold
+ .0 as usize;
+ let enable_layered_memtable = mutable_segment_switch_threshold > 0;
+ let memtable_factory = if enable_layered_memtable {
+ debug!("Enable layered memtable, mutable_segment_type:{},
mutable_segment_switch_threshold:{mutable_segment_switch_threshold}",
opts.memtable_type.to_string());
Review Comment:
It seems useless actually, we can get it by `show create table xxx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
