bvaradar commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276414411
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieLogFile.java
##########
@@ -38,54 +38,72 @@
public static final String DELTA_EXTENSION = ".log";
public static final Integer LOGFILE_BASE_VERSION = 1;
- private final Path path;
- private Optional<FileStatus> fileStatus;
+ private FileStatus fileStatus;
+ private final String pathStr;
+ private long fileLen;
public HoodieLogFile(FileStatus fileStatus) {
- this(fileStatus.getPath());
- this.fileStatus = Optional.of(fileStatus);
+ this.fileStatus = fileStatus;
+ this.pathStr = fileStatus.getPath().toString();
+ this.fileLen = fileStatus.getLen();
}
public HoodieLogFile(Path logPath) {
- this.path = logPath;
- this.fileStatus = Optional.empty();
+ this.fileStatus = null;
+ this.pathStr = logPath.toString();
+ this.fileLen = 0;
Review comment:
Made it -1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
