bvaradar commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276411029
########## File path: hoodie-common/pom.xml ########## @@ -70,6 +70,18 @@ </build> <dependencies> + <dependency> + <groupId>com.beust</groupId> + <artifactId>jcommander</artifactId> + <scope>test</scope> + <version>1.48</version> + </dependency> + + <dependency> Review comment: The current approach to allow all views (including remote, rocksdb) be instantiatable in reader side too. Hence, this would be a dependency. We can revisit to pull them out of hoodie-common to a separate dependency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
