bvaradar commented on a change in pull request #600:  Timeline Service with 
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276873853
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/io/HoodieCleanHelper.java
 ##########
 @@ -86,32 +86,38 @@ public HoodieCleanHelper(HoodieTable<T> hoodieTable, 
HoodieWriteConfig config) {
 
     for (HoodieFileGroup fileGroup : fileGroups) {
       int keepVersions = config.getCleanerFileVersionsRetained();
-      Iterator<FileSlice> fileSliceIterator = 
fileGroup.getAllFileSlices().iterator();
+      Iterator<FileSlice> fileSliceIterator = fileGroup.getAllFileSlices()
 
 Review comment:
   This was an artifact of using same timeline view across all use-case (RT, RO 
and Clean)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to