bvaradar commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276867433
########## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/view/FileSystemViewStorageConfig.java ########## @@ -0,0 +1,184 @@ +/* + * Copyright (c) 2018 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.uber.hoodie.common.table.view; + +import com.google.common.base.Preconditions; +import com.uber.hoodie.config.DefaultHoodieConfig; +import java.io.File; +import java.io.FileReader; +import java.io.IOException; +import java.util.Properties; + +/** + * File System View Storage Configurations + */ +public class FileSystemViewStorageConfig extends DefaultHoodieConfig { + + //Property Names + public static final String FILESYSTEM_VIEW_STORAGE_TYPE = "hoodie.view.type"; + public static final String FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE = "hoodie.view.secondary.type"; + public static final String FILESYSTEM_VIEW_REMOTE_HOST = "hoodie.view.remote.host"; + public static final String FILESYSTEM_VIEW_REMOTE_PORT = "hoodie.view.remote.port"; + public static final String FILESYSTEM_VIEW_SPILLABLE_DIR = "hoodie.view.spillable.dir"; + public static final String FILESYSTEM_VIEW_SPILLABLE_MEM = "hoodie.view.spillable.mem"; + public static final String FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION = + "hoodie.view.spillable.compaction.mem.fraction"; + private static final String ROCKSDB_BASE_PATH_PROP = "hoodie.view.rocksdb.base.path"; + + public static final FileSystemViewStorageType DEFAULT_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY; + public static final FileSystemViewStorageType DEFAULT_SECONDARY_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY; + public static final String DEFAULT_ROCKSDB_BASE_PATH_PROP = "/tmp/hoodie_timeline_rocksdb"; Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
