leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349322440
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ########## @@ -170,10 +168,12 @@ public static long totalNewMessages(OffsetRange[] ranges) { /** * Configs to be passed for this source. All standard Kafka consumer configs are also respected */ - static class Config { + public static class Config { Review comment: should we really need set the class to `public` just for testing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services