leesf commented on a change in pull request #1039: [HUDI-340]: made max events
to read from kafka source configurable
URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349322511
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -170,10 +168,12 @@ public static long totalNewMessages(OffsetRange[]
ranges) {
/**
* Configs to be passed for this source. All standard Kafka consumer configs
are also respected
*/
- static class Config {
+ public static class Config {
private static final String KAFKA_TOPIC_NAME =
"hoodie.deltastreamer.source.kafka.topic";
+ private static final String MAX_EVENTS_FROM_KAFKA_SOURCE_PROP =
"hoodie.deltastreamer.kafka.source.maxEvents";
private static final KafkaResetOffsetStrategies DEFAULT_AUTO_RESET_OFFSET
= KafkaResetOffsetStrategies.LARGEST;
+ public static final long DEFAULT_MAX_EVENTS_FROM_KAFKA_SOURCE = 5000000;
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
