YannByron commented on a change in pull request #4565:
URL: https://github.com/apache/hudi/pull/4565#discussion_r785454198
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -54,15 +54,20 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
private val preCombineField = tableState.preCombineField
private val recordKeyFieldOpt = tableState.recordKeyFieldOpt
private val payloadProps = if (preCombineField.isDefined) {
-
Some(HoodiePayloadConfig.newBuilder.withPayloadOrderingField(preCombineField.get).build.getProps)
+ val properties = HoodiePayloadConfig.newBuilder
+ .withPayloadOrderingField(preCombineField.get)
+ .withPayloadEventTimeField(preCombineField.get)
Review comment:
i think yes.
If not set, upsert may get a wrong result if use
`DefaultHoodieRecordPaylod`. And in spark3.2, if no `ordering.field` or
`event.time.field` found, setting `returnNullIfNotFound` to true does not take
effect when call `HoodieAvroUtils.getNestedFieldVal`, like #4169.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
