YannByron commented on a change in pull request #4565:
URL: https://github.com/apache/hudi/pull/4565#discussion_r785606065
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -729,6 +733,12 @@ object HoodieSparkSqlWriter {
mergedParams(key) = value
}
}
+
+ // use preCombineField to fill in PAYLOAD_ORDERING_FIELD_PROP_KEY and
PAYLOAD_EVENT_TIME_FIELD_PROP_KEY
+ if (mergedParams.contains(PRECOMBINE_FIELD.key())) {
+ mergedParams.put(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY,
mergedParams(PRECOMBINE_FIELD.key()))
+ mergedParams.put(HoodiePayloadProps.PAYLOAD_EVENT_TIME_FIELD_PROP_KEY,
mergedParams(PRECOMBINE_FIELD.key()))
+ }
Review comment:
but I see it didn't do that and I don't know how can run correctly
before.
btw, why `PAYLOAD_EVENT_TIME_FIELD_PROP_KEY ` is never required. After all,
`DefaultHoodieRecordPayload` will use this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
