dengziming commented on a change in pull request #1151: [WIP] [HUDI-476] Add hudi-examples module URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r368929527
########## File path: hudi-examples/src/main/java/org/apache/hudi/examples/common/HoodieExampleDataGenerator.java ########## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.examples.common; + +import org.apache.hudi.common.model.HoodieAvroPayload; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.util.HoodieAvroUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.TypedProperties; +import org.apache.hudi.utilities.schema.SchemaProvider; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecord; +import org.apache.spark.api.java.JavaSparkContext; + +import java.io.IOException; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Random; +import java.util.UUID; +import java.util.stream.Collectors; +import java.util.stream.IntStream; +import java.util.stream.Stream; + + +/** + * Class to be used to generate test data. + */ +public class HoodieExampleDataGenerator<T extends HoodieRecordPayload<T>> { Review comment: I tried to use HoodieTestDataGenerator, but this class is in the `hudi-client/src/test` directory and depends on some other test class so it's difficult to move it out. So I think the best way is to copy some code from `HoodieTestDataGenerator`, and after we move the example code in `hudi-client/src/test` to `hudi-examples` module we just delete the code in `HoodieTestDataGenerator`, and this involves much work and we can add it to the sub-tasks of HUDI-475. What do you think about it, suggestions are welcomed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
