vinothchandar commented on a change in pull request #1151: [WIP] [HUDI-476] Add hudi-examples module URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r375655701
########## File path: hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerDfsSourceExample.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.examples.deltastreamer; + +import org.apache.hudi.DataSourceWriteOptions; +import org.apache.hudi.examples.common.HoodieExampleDataGenerator; +import org.apache.hudi.examples.common.HoodieExampleSparkUtils; +import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer; +import org.apache.hudi.utilities.sources.JsonDFSSource; +import org.apache.hudi.utilities.transform.IdentityTransformer; + +import com.beust.jcommander.JCommander; +import org.apache.spark.SparkConf; +import org.apache.spark.api.java.JavaSparkContext; + + +/** + * Simple examples of #{@link HoodieDeltaStreamer} from #{@link JsonDFSSource}. + * + * To run this example, you should + * 1. prepare sample data as `hudi-examples/src/main/resources/dfs-delta-streamer` + * 2. For running in IDE, set VM options `-Dspark.master=local[2]` + * 3. For running in shell, using `spark-submit` + * + * Usage: HoodieDeltaStreamerDfsSourceExample \ Review comment: can we provide a full working command for this and all the examples? Also as a general comment, examples are great when the user can jsut hit run or execute a command and it takes care of things like data prep (step 1).. Can we make data prep part of the examples themselves and then also provide sane defaults for input/output paths.. for e.g `/tmp/hudi-examples/dfsdeltastreamer/input` and `/tmp/hudi-examples/dfsdeltastreamer/output`, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
