pratyakshsharma commented on a change in pull request #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r382758933
########## File path: hudi-common/src/main/java/org/apache/hudi/common/model/TableConfig.java ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.model; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import com.fasterxml.jackson.annotation.JsonProperty; + +import java.util.Objects; + +/* +Represents object with all the topic level overrides for multi table delta streamer execution + */ +@JsonIgnoreProperties(ignoreUnknown = true) Review comment: @bvaradar since we are going ahead with DFSPropertiesConfiguration, I am going to remove TableConfig class completely. Regarding comment having same source, yes I meant same source type. But since source class gets passed as command line parameter (--source-class), it is better to put this restriction. Because we cannot override command line parameter in source <-> sink config key value pairs. If you really want to have this flexibility of overriding source type also for every pair, I will have to define one new property in DataSourceWriteOptions and use it to configure source class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
