pratyakshsharma commented on a change in pull request #1150: [HUDI-288]: Add 
support for ingesting multiple kafka streams in a single DeltaStreamer 
deployment
URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r391206162
 
 

 ##########
 File path: 
hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
 ##########
 @@ -80,16 +79,27 @@
       + "{\"name\": \"begin_lat\", \"type\": \"double\"},{\"name\": 
\"begin_lon\", \"type\": \"double\"},"
       + "{\"name\": \"end_lat\", \"type\": \"double\"},{\"name\": \"end_lon\", 
\"type\": \"double\"},"
       + "{\"name\":\"fare\",\"type\": \"double\"}]}";
+  public static String GROCERY_PURCHASE_SCHEMA = 
"{\"type\":\"record\",\"name\":\"purchaserec\",\"fields\":["
 
 Review comment:
   So as per the design of our updates and inserts generation in 
HoodieTestDataGenerator class, we are keeping track of number of keys generated 
corresponding to a particular schema/topic. So the best that I can do is to 
have multiple topics actually consume the same schema, but the schema variable 
needs to be different for every topic. This way I will be able to track the 
number of keys generated or updated for every topic in a better way. You can 
have a look at HoodieTestDataGenerator class to get a better idea of what I am 
trying to say. I have defined the following variables now - 
   
   Map<String, Map<Integer, KeyPartition>> existingKeysBySchema;
   Map<String, Integer> numKeysBySchema;
   
    Let me know your thoughts on this @vinothchandar @bvaradar 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to